Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full view of a large (eg JSON) historical item selected from the history tab #133

Closed
sshaikh opened this issue May 17, 2023 · 5 comments

Comments

@sshaikh
Copy link

sshaikh commented May 17, 2023

Although I can see the history of a topic coming in, it's very difficult to retrieve that information, particularly as mqttui "helpfully" reformats json as a tree ;).

If the UI won't allow us to view the full content of a message in history, perhaps allow a way to copy it out?

@EdJoPaTo
Copy link
Owner

Hey! Thank you for thinking about improvements!

The reformatting of JSON should only occur in the Payload Box in the top right?
There is the idea floating around about selecting a message from the history to show its full contents in to top right payload box (see #122).
Would that work for you?

Copying stuff into the system payload from the terminal is a bit tricky if I remember that right. Maybe there is a useful rust crate to do something like that which already handles the difficult parts.

@sshaikh
Copy link
Author

sshaikh commented May 17, 2023

Correct, it only formats in the payload box (my point being that it was still difficult to extract it wholesale).

Having a view for selected history entry would be exactly what I'm requesting!

@EdJoPaTo
Copy link
Owner

Then #122 is relevant for that part of what you would need. The other part is to display JSON plainly to allow for easier copying? Maybe we should update the title of this Issue then to remember it easier.

Thanks for your input!

@sshaikh
Copy link
Author

sshaikh commented May 17, 2023

To be fair although I would appreciate (vertical, I presume?) scrolling, I'm not sure how that alone solves the issue of being able to view the actual historical item fully.

I'll try to give a more appropriate description though.

@sshaikh sshaikh changed the title Allow full view of history (or allow copying) Allow full view of a large (eg JSON) historical item selected from the history tab May 17, 2023
@EdJoPaTo EdJoPaTo added the pinned Prevent from automatically closing due to inactivity label Aug 21, 2023
@EdJoPaTo
Copy link
Owner

Copying data out is another idea that would be interesting. I opened #159 for this.

Selecting an entry from the history table is possible with the just released v0.20.0 now ✨

@EdJoPaTo EdJoPaTo removed the pinned Prevent from automatically closing due to inactivity label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants