Converting unit tests to a canonical form — work in progress #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factored out the first check from all_test_/0. That tests that startup parameters passed to mcd_cluster:start_link/2 are honored. Therefore: • Made the test explicit; it is now a separate tests. • Nonessential details (such as result of the start/stop calls) are not checked, since if they fail the test will fail anyways. • Factored out mcd_node/1 to hide nonessential details (how the node is specified). All we test is that the node id is visible after startup, so it's left there.
Factored out the first check from all_test_/0. It tests that startup parameters passed to mcd_cluster:start_link/2 are honored. Therefore: • Made the check explicit; it is now a separate tests. • Nonessential details (such as result of the start/stop calls) are not checked, since if they fail the test will fail anyways. • Factored out mcd_node/1 to hide nonessential details (how the node is specified). All we test is that the node id is visible after startup, so it's left there.
check_using_startup_args_test -> using_startup_args_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.