improve resources found fixing EbookFoundation/free-programming-books-parser#8 #7090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davorpa
changed the title
davorpa
changed the title
davorpa
added
🗣️ locale:en
|
@eshellman should I open again the PR? Any reason to revert it in 2e2bb31? Let me know what happened to improve and go ahead |
|
not sure what happened - maybe escaping messed up link checker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add info | Improve repo
For resources
Description
Improve resource bugs found fixing EbookFoundation/free-programming-books-parser#8 in PR EbookFoundation/free-programming-books-parser#11
Why is this valuable (or not)?
Fixes the format of found items due to the flow change and completes their info (creators, format, notes...)
Checklist:
Follow-up