-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve title text extraction #8
Comments
Could you present an example from our current parsed data? Thanks |
Not at all since EbookFoundation/free-programming-books#7086 has been already fixed. Anyway I see you merge #11. Should I do anything more? |
I think we're good |
According to current code
free-programming-books-parser/index.js
Lines 92 to 95 in dc53b8c
first node
children[0]
is used as resource titles without check if there are more meaningfull tokens. So the rest is stripped making sometimes difficult to do a search by title of resources.Therefore a escape in resources title links part is needed when submitting and make a rebuild Markdown here is mandatory
Context
See EbookFoundation/free-programming-books#7086
Related with #2 (same workarround)
The text was updated successfully, but these errors were encountered: