Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: buying a pickup when providing a rate #341

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: buying a pickup when providing a rate #341

merged 1 commit into from
Jan 3, 2025

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Jan 2, 2025 •
edited
Loading

Description

Testing

  • Updates tests to pass proper params

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 marked this pull request as ready for review January 2, 2025 22:30
@Justintime50 Justintime50 requested a review from a team as a code owner January 2, 2025 22:30
@Justintime50 Justintime50 merged commit a631ce9 into master Jan 3, 2025
21 checks passed
@Justintime50 Justintime50 deleted the fix_pickup_buy_rate branch January 3, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwithan8 nwithan8 nwithan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: pickup.buy(String, PickupRate) wrong params in POST request
2 participants
@Justintime50 @nwithan8