remove prefix check for PaymentId

EasyPost · Apr 10, 2024 · 3946aba · 3946aba
1 parent 07bf462
commit 3946aba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 28 deletions.
diff --git a/src/main/java/com/easypost/model/PaymentMethodObject.java b/src/main/java/com/easypost/model/PaymentMethodObject.java
@@ -60,9 +60,9 @@ public PaymentMethodType getType() {
             return null;
         }
         String objectType = getObject();
-        if (getId().startsWith("card_") || (objectType != null && objectType.equals("CreditCard"))) {
+        if (objectType != null && objectType.equals("CreditCard")) {
             type = PaymentMethodType.CREDIT_CARD;
-        } else if (getId().startsWith("bank_") || (objectType != null && objectType.equals("BankAccount"))) {
+        } else if (objectType != null && objectType.equals("BankAccount")) {
             type = PaymentMethodType.BANK_ACCOUNT;
         }
         return type;

diff --git a/src/test/java/com/easypost/BillingTest.java b/src/test/java/com/easypost/BillingTest.java
@@ -139,30 +139,4 @@ public void testDeterminePaymentMethodTypeByObjectType() throws EasyPostExceptio
         assertEquals("BankAccount", bankAccount.getObject());
         assertEquals(PaymentMethodObject.PaymentMethodType.BANK_ACCOUNT, bankAccount.getType());
     }
-
-    /**
-     * Test determining a payment method type by its legacy prefix.
-     *
-     * @throws EasyPostException when the request fails.
-     */
-    @Test
-    public void testDeterminePaymentMethodTypeByLegacyPrefix() throws EasyPostException {
-        requestMock.when(() -> Requestor.request(
-                RequestMethod.GET, "payment_methods", null, PaymentMethod.class, vcr.client))
-                .thenReturn(paymentMethodLegacyPrefixes);
-
-        // Should be a credit card with null object type and "card_" prefix
-        PaymentMethodObject creditCard =
-                vcr.client.billing.retrievePaymentMethods().getPrimaryPaymentMethod();
-        assertTrue(creditCard.getId().startsWith("card_"));
-        assertNull(creditCard.getObject());
-        assertEquals(PaymentMethodObject.PaymentMethodType.CREDIT_CARD, creditCard.getType());
-
-        // Should be a bank account with null object type and "bank_" prefix
-        PaymentMethodObject bankAccount =
-                vcr.client.billing.retrievePaymentMethods().getSecondaryPaymentMethod();
-        assertTrue(bankAccount.getId().startsWith("bank_"));
-        assertNull(bankAccount.getObject());
-        assertEquals(PaymentMethodObject.PaymentMethodType.BANK_ACCOUNT, bankAccount.getType());
-    }
 }