2.5.3.1 preparation #818
Merged
2.5.3.1 preparation #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deprecation and the GitHub Security Advisory.
It referenced an obsolete ESAPI property that was renamed to 'Validator.HtmlValidationAction'.
|
@xeno6696 - This should be really fast to review. The code changes are minimal (limited to |
xeno6696
approved these changes
Nov 30, 2023
| @@ -382,6 +386,12 @@ public Date getValidDate(String context, String input, DateFormat format, boolea | |||
| */ | |||
| @Override | |||
| public boolean isValidSafeHTML(String context, String input, int maxLength, boolean allowNull) { | |||
| // Ensure a message about deprecation is logged once if this or the | |||
There was a problem hiding this comment.
Yep, this is pretty much straight up/downvote.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESAPI 2.5.3.1 is a minor point release that adds:
Validator.isValidSafeHTMLandValidationRule.getValidmethods.isValidSafeHTMLmethods is invoked. The warning notes that the method is deprecated and provides a link to the GitHub Security Advisory.