ENCM-265-query-string-order #4449
Open
+26
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sort all `type=` query-string elements to the front of all query strings. * Reduced two simple loops to separate `type=` from other queries to a single more complex loop. Use a more reliable method to get the key value when formatting. Improve comments. * Fix query-string Jest tests to adjust to the `type=` ordering change.
There was a problem hiding this comment.
Pull Request Overview
This PR implements query string ordering functionality to ensure type= parameters are moved to the front of query strings to avoid requests getting blocked.
- Modifies the
format()method to sorttype=elements to the beginning of query strings - Updates tests to reflect the new ordering behavior where
type=parameters appear first
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/encoded/static/libs/query_string.js | Updates format() method to sort type= elements to front and fixes key extraction logic |
| src/encoded/static/libs/tests/query_string-test.js | Updates test expectations to match new type= first ordering behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pedrohr
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.