-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make disable on site more prominent #2787
Conversation
This comment has been minimized.
This comment has been minimized.
Larger text + shadow to make the button "pop"
Thanks for these tweaks! I'm definitely in favor of simplifying the report button message as well. That's a keeper. I'm on the fence about the rounded corners for the buttons. On the one hand, it does kinda fall in line with how many other web things style their buttons, so it appeals to that sense of familiarity with people. On the other hand, the curve radius on the button is just different enough from the highlighted blocked resources outlines that it's noticeable and kind of bothersome. I'm not in favor of the drop shadow on the power button, however. I think it's a little visually confusing when you see it, since it's the only thing in the popup that would have that kind of lifted dimension. |
f34a677
to
ea5cf91
Compare
ea5cf91
to
4ea6261
Compare
Related to #2781, #2021. Supersedes #2660.
This makes some more cosmetic changes to the popup to make the disable and enable buttons more prominent.