Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize sliders into expandable summary, add first party protections section #2748

Merged
merged 52 commits into from
May 14, 2021
Merged

Organize sliders into expandable summary, add first party protections section #2748

merged 52 commits into from
May 14, 2021

Commits on Mar 28, 2021

  1. add messages to english locale for firstparty protections info in popup

    @ablanathtanalba
    ablanathtanalba committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    65ffbf0 View commit details
    Browse the repository at this point in the history

  2. add section to popup html for firstparty protections

    @ablanathtanalba
    ablanathtanalba committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    d14a37b View commit details
    Browse the repository at this point in the history

  3. basic styling to firstparty section in popup

    @ablanathtanalba
    ablanathtanalba committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    ae0809e View commit details
    Browse the repository at this point in the history

  4. add click handlers to toggle firstparty info visibility on popup

    @ablanathtanalba
    ablanathtanalba committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    4e59434 View commit details
    Browse the repository at this point in the history

  5. add popup html for toggling blocked resources visibility

    @ablanathtanalba
    ablanathtanalba committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    108661e View commit details
    Browse the repository at this point in the history

  6. add click handlers for toggling blocked resources visibility in popup

    @ablanathtanalba
    ablanathtanalba committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    7938eb2 View commit details
    Browse the repository at this point in the history

  7. basic persistence of blocked resources visibility preference in popup

    @ablanathtanalba
    ablanathtanalba committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    330322c View commit details
    Browse the repository at this point in the history

  8. fix selenium popup test by clicking to expand blocked resources section

    @ablanathtanalba
    ablanathtanalba committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    abb3fa8 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. fix styling edge case where no trackers detected but firstparty prote… 

    …ction is enabled
    @ablanathtanalba
    ablanathtanalba committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    d959710 View commit details
    Browse the repository at this point in the history

  2. styling cleanup on firstparty text and hidden sliders in popup

    @ablanathtanalba
    ablanathtanalba committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    7040294 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. add en_us message for popup click to expand tooltips

    @ablanathtanalba
    ablanathtanalba committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    bc6e930 View commit details
    Browse the repository at this point in the history

  2. cleanup click to expand section event listeners in popup script

    @ablanathtanalba
    ablanathtanalba committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    0bedddb View commit details
    Browse the repository at this point in the history

  3. cleanup click handler for blocked resources section in popup

    @ablanathtanalba
    ablanathtanalba committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    9af80f2 View commit details
    Browse the repository at this point in the history

  4. cleanup styling for dropdown portions of popup

    @ablanathtanalba
    ablanathtanalba committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    ca7c71d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. more css cleanup for expandable popup sections

    @ablanathtanalba
    ablanathtanalba committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    111e8a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. set firstparties url schemes to badger object

    @ablanathtanalba
    ablanathtanalba committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    97ace1f View commit details
    Browse the repository at this point in the history

  2. handle checking if current tab is in firstparty protections in webreq… 

    …uest
    @ablanathtanalba
    ablanathtanalba committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    786691f View commit details
    Browse the repository at this point in the history

  3. cleanup popup script handlers showing firstparty and blocked resource… 

    …s messages
    @ablanathtanalba
    ablanathtanalba committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    501ccaa View commit details
    Browse the repository at this point in the history

  4. fix broken selenium popup test selecting wrong element type

    @ablanathtanalba
    ablanathtanalba committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    c2a7b79 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. simplify firstparty popup message

    @ablanathtanalba
    ablanathtanalba committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    874c3f0 View commit details
    Browse the repository at this point in the history

  2. add hover transform effect on popup dropdown carets

    @ablanathtanalba
    ablanathtanalba committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    380156a View commit details
    Browse the repository at this point in the history

  3. remove tooltip from dropdown sections popup

    @ablanathtanalba
    ablanathtanalba committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    53fa187 View commit details
    Browse the repository at this point in the history

  4. move firstparty detection method to utils

    @ablanathtanalba
    ablanathtanalba committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    8d0c014 View commit details
    Browse the repository at this point in the history

  5. add unit test for firstparty detection util method

    @ablanathtanalba
    ablanathtanalba committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    68b04f8 View commit details
    Browse the repository at this point in the history

  6. cleanup fetching manifest in background script

    @ablanathtanalba
    ablanathtanalba committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    6598953 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. cleanup and delint method to check if firstparty protections are enab… 

    …led on a url
    @ablanathtanalba
    ablanathtanalba committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    58b68b6 View commit details
    Browse the repository at this point in the history

  2. fix cursor hovering error on popup expandable sections

    @ablanathtanalba
    ablanathtanalba committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    825d69e View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. cleanup badger firstparties list obj and avoid false positives when l… 

    …ooking through it
    @ablanathtanalba
    ablanathtanalba committed May 3, 2021
    1 Configuration menu
    Copy the full SHA
    63c7f3d View commit details
    Browse the repository at this point in the history

  2. fix broken firstparty detection test script

    @ablanathtanalba
    ablanathtanalba committed May 3, 2021
    Configuration menu
    Copy the full SHA
    0c098a1 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. fix wildcard url matching firstparty detection and add test coverage

    @ablanathtanalba
    ablanathtanalba committed May 6, 2021
    Configuration menu
    Copy the full SHA
    cad1393 View commit details
    Browse the repository at this point in the history

  2. simplify updating setting showing blocked resources container in popup

    @ablanathtanalba
    ablanathtanalba committed May 6, 2021
    Configuration menu
    Copy the full SHA
    6408edb View commit details
    Browse the repository at this point in the history

  3. visual consistency between descriptions sections in dropdowns on popup

    @ablanathtanalba
    ablanathtanalba committed May 6, 2021
    Configuration menu
    Copy the full SHA
    284907b View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. only fetch badger firstparties list when its first needed

    @ablanathtanalba
    ablanathtanalba committed May 10, 2021
    Configuration menu
    Copy the full SHA
    123b2a4 View commit details
    Browse the repository at this point in the history

  2. fix broken utils text

    @ablanathtanalba
    ablanathtanalba committed May 10, 2021
    Configuration menu
    Copy the full SHA
    7438813 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Move HTML link into a placeholder 

    Friendlier to translators and easier to update the link in the future
(avoids having to "retranslate" every message).
    @ghostwords
    ghostwords committed May 12, 2021
    Configuration menu
    Copy the full SHA
    98b2e84 View commit details
    Browse the repository at this point in the history

  2. Tweak locale message order 

    More logical for translators: in the UI the header comes first,
before the "more info" text.
    @ghostwords
    ghostwords committed May 12, 2021
    Configuration menu
    Copy the full SHA
    c5fb566 View commit details
    Browse the repository at this point in the history

  3. Tweak link tracking protection messages

    @ghostwords
    ghostwords committed May 12, 2021
    Configuration menu
    Copy the full SHA
    09a602a View commit details
    Browse the repository at this point in the history

  4. Restyle popup categories 

    Also:

- Link tracking protection moved above sliders
- Keyboard support
- Dark mode styles
- RTL locale support
    @ghostwords
    ghostwords committed May 12, 2021
    Configuration menu
    Copy the full SHA
    b778566 View commit details
    Browse the repository at this point in the history

  5. Don't toggle slider visibility when clicking links 

    In the header.
    @ghostwords
    ghostwords committed May 12, 2021
    Configuration menu
    Copy the full SHA
    e4f0d64 View commit details
    Browse the repository at this point in the history

  6. Fix reverting control test

    @ghostwords
    ghostwords committed May 12, 2021
    Configuration menu
    Copy the full SHA
    5b3453a View commit details
    Browse the repository at this point in the history

  7. Revert "pbInstructions" to ID as there is only one

    @ghostwords
    ghostwords committed May 12, 2021
    Configuration menu
    Copy the full SHA
    1a97a81 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. cleanup util method to check if firstparty protections are enabled

    @ablanathtanalba
    ablanathtanalba committed May 13, 2021
    Configuration menu
    Copy the full SHA
    d2b7f5b View commit details
    Browse the repository at this point in the history

  2. simplify checking against wildcards in firstPartyProtectionsEnabled u… 

    …til method
    @ablanathtanalba
    ablanathtanalba committed May 13, 2021
    Configuration menu
    Copy the full SHA
    95dfb69 View commit details
    Browse the repository at this point in the history

  3. Expand sliders always on any breakage warnings

    @ghostwords
    ghostwords committed May 13, 2021
    Configuration menu
    Copy the full SHA
    b86df58 View commit details
    Browse the repository at this point in the history

  4. Show breakage warning sliders above the rest

    @ghostwords
    ghostwords committed May 13, 2021
    Configuration menu
    Copy the full SHA
    75127cd View commit details
    Browse the repository at this point in the history

  5. Tweak unit tests

    @ghostwords
    ghostwords committed May 13, 2021
    Configuration menu
    Copy the full SHA
    48d2b2a View commit details
    Browse the repository at this point in the history

  6. Tweak firstPartyProtectionsEnabled() documentation

    @ghostwords
    ghostwords committed May 13, 2021
    Configuration menu
    Copy the full SHA
    ea35530 View commit details
    Browse the repository at this point in the history

  7. Tweak link tracking protection wording

    @ghostwords
    ghostwords committed May 13, 2021
    Configuration menu
    Copy the full SHA
    ff82451 View commit details
    Browse the repository at this point in the history

  8. Fix no-tab-data (special browser page) popup state

    @ghostwords
    ghostwords committed May 13, 2021
    Configuration menu
    Copy the full SHA
    7abed9e View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Tweak link tracking protection wording again

    @ghostwords
    ghostwords committed May 14, 2021
    Configuration menu
    Copy the full SHA
    d6e318b View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary CSS IDs

    @ghostwords
    ghostwords committed May 14, 2021
    Configuration menu
    Copy the full SHA
    9089db1 View commit details
    Browse the repository at this point in the history

  3. Send all settings in single object to popup too

    @ghostwords
    ghostwords committed May 14, 2021
    Configuration menu
    Copy the full SHA
    aa4fe37 View commit details
    Browse the repository at this point in the history