Show firstparty protections ui #2684
Conversation
|
Oh, and the link that the new text points to is the deeplinks blog post that describes PB's link tracking protections: https://www.eff.org/deeplinks/2018/05/privacy-badger-rolls-out-new-ways-fight-facebook-tracking |
ablanathtanalba
force-pushed
the
show_firstparty_protections_ui
branch
from
eef1669
to
2177080
Compare
|
Rebased on master and added another commit to simplify messaging into one case for all variations of the popup, regardless of current detected tracker count. |
ablanathtanalba
added
the
ui
src/js/popup.js
Outdated
| @@ -169,6 +169,11 @@ function init() { | |||
| $overlay.toggleClass('active'); | |||
| } | |||
|
|
|||
| // show firstparty link tracking protection if we scrub links on this tab host | |||
| if (POPUP_DATA.tabHost == 'www.facebook.com' || POPUP_DATA.tabHost == 'www.google.com') { | |||
There was a problem hiding this comment.
This doesn't cover all the domains we perform link unwrapping on. Take a look at domains we inject /firstparties/ content scripts into in manifest.json.
There was a problem hiding this comment.
fixed this to pull down all domains from our manifest
|
Cool, thanks for the feedback. I hit on each of the smaller points and added some dynamic checking to cover all first party urls and future ones. |
|
here's an updated pic for how this change looks in the popup: |
…yle of popup messaging
ablanathtanalba
force-pushed
the
show_firstparty_protections_ui
branch
from
18b1ade
to
a1afda3
Compare
|
This is gonna be wrapped up in #2748, so I'm closing this in favor of that one |
Fixes #2482
This adds a new message to the badger popup when any of the first party scripts are being run on the user's current site. If in the future the first party scripts are doing things other than anchor tag scrubbing, then maybe we could change the messaging.... until then, this oughtta work!