Add support for time intervals in HH:MM:SS and similar formats#329
Merged
xylar merged 3 commits intoE3SM-Project:developfrom Feb 2, 2026
Merged
Add support for time intervals in HH:MM:SS and similar formats#329xylar merged 3 commits intoE3SM-Project:developfrom
xylar merged 3 commits intoE3SM-Project:developfrom
Conversation
These exercise the `TimeInterval(std::string&)` constructor used by `TimeIntegration` options like `TimeStep` and `RunDuration`. For now, we're verifying that `DDDD_HH:MM:SS` type formats work and `HH:MM:SS` (and shorter) formats fail. Later, we will implement support for these shorter formats and verify that they, too work.
This merge adds support for time intervals in the following formats: - DDDD_HH:MM:SS(.sss...) - HH:MM:SS(.sss...) - MM:SS(.sss...) - SS(.sss...) This will make compatibility with Polaris and MPAS-Ocean simpler.
Author
TestingTwo new CTests were added to verify time-interval string support:
CTest unit tests:
Polaris
|
Author
|
@brian-oneill, would you be willing to review this? |
|
Looks good, parser handles all the different forms correctly. Ran the ctests successfully on pm-cpu and pm-gpu. |
brian-oneill
approved these changes
Feb 1, 2026
Author
|
Thank you for the testing and review, @brian-oneill! |
xylar
added a commit
to xylar/polaris
that referenced
this pull request
Feb 2, 2026
This merge updates the e3sm_submodules/Omega submodule from [f2e951a](https://github.com/E3SM-Project/Omega/tree/f2e951a) to [fc53608](https://github.com/E3SM-Project/Omega/tree/fc53608). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/Omega#325 - [ ] (ocn) E3SM-Project/Omega#329
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge adds support for time intervals in the following formats:
DDDD_HH:MM:SS(.sss...)(previously supported)HH:MM:SS(.sss...)MM:SS(.sss...)SS(.sss...)This will make compatibility with Polaris and MPAS-Ocean simpler, see E3SM-Project/polaris#444.
Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR buildafter.
Fixes E3SM-Project/polaris#444