-
Notifications
You must be signed in to change notification settings - Fork 6
Update OmegaV1GoverningEqns.md #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update OmegaV1GoverningEqns.md #324
Conversation
I found that this change would require many updates in both Omega and Polaris. I don’t think it’s necessary at this point, so we should keep using |
mark-petersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hyungyukang thanks for your attention to the documentation. This looks good to me.
- Update definition of unit normal since the current definition is actually upward normal
|
@hyungyukang, I also noticed several issues with this document. Most are different from your changes but I think a few may overlap. After we merge your fixes, I would like to rebase #326 and have you take a look at that. |
- Remove \rho_0 in (64) and add \tilde to (63)
I would be strongly in favor or renaming |
This PR slightly modifies the Omega-V1 governing equation document OmegaV1GoverningEqns.md.
Variable Definitionsto match its usage in the documentCompiled version is here.
The code needs to be updated (e.g., changing
LayerThicknesstoPseudoThickness) to match the document. I will open another PR for this.Checklist