Skip to content

Conversation

@hyungyukang
Copy link

@hyungyukang hyungyukang commented Dec 3, 2025

This PR slightly modifies the Omega-V1 governing equation document OmegaV1GoverningEqns.md.

  • Fix some bugs in formulations
  • Update definition and units in Variable Definitions to match its usage in the document

Compiled version is here.

The code needs to be updated (e.g., changing LayerThickness to PseudoThickness) to match the document. I will open another PR for this.

Checklist

@hyungyukang hyungyukang changed the title Fix bugs in formulations and improve the document Update OmegaV1GoverningEqns.md Dec 3, 2025
@hyungyukang
Copy link
Author

The code needs to be updated (e.g., changing LayerThickness to PseudoThickness) to match the document. I will open another PR for this.

I found that this change would require many updates in both Omega and Polaris. I don’t think it’s necessary at this point, so we should keep using LayerThickness for $\tilde{h}$ and GeometricLayerThickness for $h$.

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyungyukang thanks for your attention to the documentation. This looks good to me.

- Update definition of unit normal since the current definition is
  actually upward normal
@xylar
Copy link

xylar commented Dec 15, 2025

@hyungyukang, I also noticed several issues with this document. Most are different from your changes but I think a few may overlap. After we merge your fixes, I would like to rebase #326 and have you take a look at that.

- Remove \rho_0 in (64) and add \tilde to (63)
@xylar
Copy link

xylar commented Dec 19, 2025

The code needs to be updated (e.g., changing LayerThickness to PseudoThickness) to match the document. I will open another PR for this.

I found that this change would require many updates in both Omega and Polaris. I don’t think it’s necessary at this point, so we should keep using LayerThickness for $\tilde{h}$ and GeometricLayerThickness for $h$.

I would be strongly in favor or renaming LayerThickness to PseudoThickness to avoid confusion in both Omega and Polaris. I will try to get the ball rolling, even knowing that this will be quite disruptive. It won't be better if we wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants