Add Pressure Gradient design document#226
Add Pressure Gradient design document#226sbrus89 wants to merge 6 commits intoE3SM-Project:developfrom
Conversation
sbrus89
requested review from
alicebarthel,
katsmith133,
mark-petersen,
mwarusz,
philipwjones,
vanroekel and
xylar
vanroekel
left a comment
vanroekel
left a comment
There was a problem hiding this comment.
Looks good, just a couple tiny questions from me.
|
Test compiled and posted here. |
components/omega/doc/design/PGrad.md
Outdated
| ## Verification and Testing | ||
|
|
||
| ### Test: Spatial convergence to exact solution | ||
| For a given analytical $v$, $h$, and $b$, the spatial convergence of the pressure gradient can be assessed by computing errors on progressively finer meshes. |
There was a problem hiding this comment.
I think maybe this should be fleshed out a bit more. What analytic test would we use?
There was a problem hiding this comment.
I revised this part slightly. I think we just need to specify arbitrary functions for the
sbrus89
force-pushed
the
omega/pgrad-design
branch
4 times, most recently
from
674c345 to
16c3c49
Compare
sbrus89
force-pushed
the
omega/pgrad-design
branch
from
16c3c49 to
c32bbb2
Compare
|
Latest version compiled here. |
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Thanks for your work on this. It looks great!
Co-authored-by: Mark Petersen <mark.petersen.la@gmail.com>
xylar
left a comment
xylar
left a comment
There was a problem hiding this comment.
A few comments on the design doc, all of them small and hopefully easy to address.
| ### Test: Baroclinic gyre | ||
| The baroclinic gyre test case will test the pressure gradient term in the full non-Boussinesq equations. |
There was a problem hiding this comment.
I don't think we'll have the baroclinic gyre test in time for our testing needs.
Let's link to the seamount and the overflow test cases here (actually liking to the Polaris docs).
And we'll add my 2-column test as soon as I have a draft PR.
7 participants
This PR adds the design document for the pressure gradient module for Omega-1. Compiled version here.
Checklist