Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open feat 031224 #190

Merged
merged 49 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
08abd87
legal: Fix copyright
vasylskorych Sep 7, 2024
a415d73
feat: Parameter-dependent unit structure
vasylskorych Dec 3, 2024
7696626
refactor: Initialize pointers
vasylskorych Dec 3, 2024
513cd68
feat: Change H5Handler API
vasylskorych Dec 3, 2024
9844606
feat: New names of units constructors.
vasylskorych Dec 3, 2024
ab16097
feat: Change H5Handler API
vasylskorych Dec 3, 2024
c9fab79
fix: Remove duplicates
vasylskorych Dec 3, 2024
73f1fb5
feat: String converters
vasylskorych Dec 3, 2024
2791765
fix: Parameter-dependent unit structure
vasylskorych Dec 3, 2024
8551814
build: Ignore warnings
vasylskorych Dec 3, 2024
bb336cb
refactor: Remove unused EPortType
vasylskorych Dec 3, 2024
7f123ec
feat: Add VectorContains function
vasylskorych Dec 3, 2024
1d7e273
legal: Update copyright
vasylskorych Dec 3, 2024
83af8c7
feat: CQtTree::CreateItem
vasylskorych Dec 3, 2024
51797ee
feat: Add new CQtTable::SetComboBox version
vasylskorych Dec 3, 2024
47deaeb
feat: Add internal API functions to CBaseStream
vasylskorych Dec 3, 2024
e68282f
feat: Core API update
vasylskorych Dec 3, 2024
e2b8f4f
feat: QtTable::GetItemUserData, GetCurrentItemUserData
vasylskorych Dec 3, 2024
8cede78
docs: Fix API comment
vasylskorych Dec 3, 2024
d8d8727
fix(core): Ensure holdups and feeds have at least one time point on c…
vasylskorych Dec 3, 2024
2a6c803
feat: CQtTable::EnableBlockOnPaste
vasylskorych Dec 3, 2024
8c3fa11
refactor: CQtTable::Paste
vasylskorych Dec 3, 2024
3cc3af0
fix(Core): Skip empty phases during the check of the flowsheet
vasylskorych Dec 3, 2024
3e0f976
feat(API): Get number of init objects in CStreamManager
vasylskorych Dec 3, 2024
bd19440
build: Fix build errors
vasylskorych Dec 3, 2024
67e3f90
build(Windows): Qt-related fixes
vasylskorych Dec 3, 2024
86630db
style: Rearrange includes
vasylskorych Dec 3, 2024
589d607
docs: Rearrange list of external libs
vasylskorych Dec 3, 2024
6cee6f9
refactor: Split UnitParameters file
vasylskorych Dec 3, 2024
13a6b39
docs: Add new files to docs
vasylskorych Dec 3, 2024
8e36a3a
refactor: Work with DISTR_NAMES
vasylskorych Dec 3, 2024
679ab52
feat(API): CBaseUnit::GetAllOverallProperties()
vasylskorych Dec 3, 2024
07ca58a
refactor: Enum value
vasylskorych Dec 3, 2024
ce2c1ee
feat: New functions of QtTable
vasylskorych Dec 3, 2024
a7d5934
refactor: UnitParameterCollection
vasylskorych Dec 3, 2024
416d41d
feat: New functions of QTable
vasylskorych Dec 3, 2024
986c00a
feat: UnitParametersManager::IsGrouping
vasylskorych Dec 3, 2024
c674b0b
feat: UnitParameterCollection::Has
vasylskorych Dec 3, 2024
01a820c
legal: Copyright notice
vasylskorych Dec 3, 2024
f54e569
feat(API): Add functions
vasylskorych Dec 3, 2024
928d31e
feat(API): Allow to group unit parameters with checkboxes
vasylskorych Dec 3, 2024
772de41
feat(API): Convenience functions
vasylskorych Dec 3, 2024
fe62ad1
fix(core): Possible infinite loop
vasylskorych Dec 3, 2024
168e44d
feat: QtTable clear up
vasylskorych Dec 3, 2024
a73ebfa
fix(core): Fix grouping parameters
vasylskorych Dec 3, 2024
04012f3
ci: Fix Qt settings
vasylskorych Dec 4, 2024
82e1677
ci: New Qt tools
vasylskorych Dec 4, 2024
50534ed
ci: Fix Ubuntu version
vasylskorych Dec 4, 2024
2d0ead1
Revert "ci: Fix Qt settings"
vasylskorych Dec 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on: [push]
jobs:
build:
name: ${{ matrix.name }}
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
include:
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:

docs:
name: Docs
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: build

steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:
# Versions
QT_VERSION: 5.15.2
QT_VS_VERSION: msvc2019_64
QT_VS_ADDIN_VERSION: 3.0.2
QT_VS_ADDIN_VERSION: 3.3.1
ZLIB_VERSION: 1.3
SUNDIALS_VERSION: 6.4.1
HDF5_VERSION: 1.12.2
Expand Down Expand Up @@ -70,7 +70,7 @@ jobs:
# Also, it installs them to %LOCALAPPDATA%\QtMsBuild, so they can not be used by other Windows users.
# Download the extension and extract requited files to the project directory.
run: |
Invoke-WebRequest -Uri https://ftp.fau.de/qtproject/archive/vsaddin/${{env.QT_VS_ADDIN_VERSION}}/qt-vsaddin-msvc2019-${{env.QT_VS_ADDIN_VERSION}}.vsix -MaximumRetryCount 10 -RetryIntervalSec 30 -OutFile vspackage.vsix
Invoke-WebRequest -Uri https://ftp.fau.de/qtproject/archive/vsaddin/${{env.QT_VS_ADDIN_VERSION}}/qt-vsaddin-msvc2019-x86-${{env.QT_VS_ADDIN_VERSION}}.vsix -MaximumRetryCount 10 -RetryIntervalSec 30 -OutFile vspackage.vsix
Expand-Archive vspackage.vsix -DestinationPath ${{github.workspace}}/ExternalLibraries/qtvsaddin

- name: Cache ZLib
Expand Down Expand Up @@ -270,7 +270,7 @@ jobs:
# Also, it installs them to %LOCALAPPDATA%\QtMsBuild, so they can not be used by other Windows users.
# Download the extension and extract requited files to the project directory.
run: |
Invoke-WebRequest -Uri https://ftp.fau.de/qtproject/archive/vsaddin/${{env.QT_VS_ADDIN_VERSION}}/qt-vsaddin-msvc2019-${{env.QT_VS_ADDIN_VERSION}}.vsix -MaximumRetryCount 10 -RetryIntervalSec 30 -OutFile vspackage.vsix
Invoke-WebRequest -Uri https://ftp.fau.de/qtproject/archive/vsaddin/${{env.QT_VS_ADDIN_VERSION}}/qt-vsaddin-msvc2019-x86-${{env.QT_VS_ADDIN_VERSION}}.vsix -MaximumRetryCount 10 -RetryIntervalSec 30 -OutFile vspackage.vsix
Expand-Archive vspackage.vsix -DestinationPath ${{github.workspace}}/ExternalLibraries/qtvsaddin

- name: Cache ZLib
Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ IF(BUILD_DOCS)
"ModelsAPI/Stream"
"ModelsAPI/TransformMatrix"
"ModelsAPI/UnitParameters"
"ModelsAPI/UnitParametersEnum"
"ModelsAPI/UnitParametersManager"
"ModelsAPI/UnitPorts"
"BaseSolvers/AgglomerationSolver"
"BaseSolvers/BaseSolver"
Expand Down
3 changes: 3 additions & 0 deletions Documentation/004_development/constants.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ Dyssol constants
.. doxygenenum:: EUnitPort
:project: dyssol_models_api

.. doxygenenum:: EUnitParameter
:project: dyssol_models_api

.. doxygenenum:: EPhase
:project: dyssol_models_api

Expand Down
8 changes: 2 additions & 6 deletions DyssolGUI/DyssolGUI.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,18 @@
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonDebug.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonRelease.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt_defaults.props')">
<Import Project="$(QtMsBuild)\qt_defaults.props" />
</ImportGroup>
<PropertyGroup Label="QtSettings" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<QtInstall>msvc2019_64</QtInstall>
<QtModules>core;gui;widgets</QtModules>
Expand Down Expand Up @@ -161,9 +160,6 @@
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</ExcludedFromBuild>
</Image>
</ItemGroup>
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.props')">
<Import Project="$(QtMsBuild)\qt.props" />
</ImportGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.targets')">
<Import Project="$(QtMsBuild)\qt.targets" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,18 @@
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonDebug.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonRelease.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt_defaults.props')">
<Import Project="$(QtMsBuild)\qt_defaults.props" />
</ImportGroup>
<PropertyGroup Label="QtSettings" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<QtInstall>msvc2019_64</QtInstall>
<QtModules>widgets</QtModules>
Expand All @@ -81,9 +80,6 @@
<PropertyGroup>
<_ProjectFileVersion>10.0.40219.1</_ProjectFileVersion>
</PropertyGroup>
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.props')">
<Import Project="$(QtMsBuild)\qt.props" />
</ImportGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.targets')">
<Import Project="$(QtMsBuild)\qt.targets" />
Expand Down
8 changes: 2 additions & 6 deletions GUIDialogs/CompoundsManager/CompoundsManager.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,18 @@
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonDebug.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonRelease.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt_defaults.props')">
<Import Project="$(QtMsBuild)\qt_defaults.props" />
</ImportGroup>
<PropertyGroup Label="QtSettings" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<QtInstall>msvc2019_64</QtInstall>
<QtModules>widgets</QtModules>
Expand All @@ -75,9 +74,6 @@
<PropertyGroup>
<_ProjectFileVersion>10.0.40219.1</_ProjectFileVersion>
</PropertyGroup>
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.props')">
<Import Project="$(QtMsBuild)\qt.props" />
</ImportGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.targets')">
<Import Project="$(QtMsBuild)\qt.targets" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,18 @@
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonDebug.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonRelease.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt_defaults.props')">
<Import Project="$(QtMsBuild)\qt_defaults.props" />
</ImportGroup>
<PropertyGroup Label="QtSettings" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<QtInstall>msvc2019_64</QtInstall>
<QtModules>widgets</QtModules>
Expand All @@ -86,9 +85,6 @@
<QtMoc>
</QtMoc>
</ItemDefinitionGroup>
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.props')">
<Import Project="$(QtMsBuild)\qt.props" />
</ImportGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.targets')">
<Import Project="$(QtMsBuild)\qt.targets" />
Expand Down
5 changes: 4 additions & 1 deletion GUIDialogs/FlowsheetEditor/FlowsheetEditor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ void CFlowsheetEditor::InitializeConnections()
connect(ui.buttonAddListValue, &QPushButton::clicked, this, &CFlowsheetEditor::AddUnitParamListItem);
connect(ui.buttonRemoveListValue, &QPushButton::clicked, this, &CFlowsheetEditor::DeleteUnitParamListItem);
connect(ui.tableListValues, &QTableWidget::itemChanged, this, &CFlowsheetEditor::ListValueChanged);
connect(ui.tableListValues, &CQtTable::PasteInitiated, this, &CFlowsheetEditor::PasteParamTable);
connect(ui.tableListValues, &CQtTable::PasteStarted, this, &CFlowsheetEditor::PasteParamTable);


connect(ui.tableUnitParams, &QTableWidget::itemSelectionChanged, this, &CFlowsheetEditor::NewUnitParameterSelected);
Expand Down Expand Up @@ -532,6 +532,9 @@ void CFlowsheetEditor::UnitParamValueChanged(int _row, int _col)
break;
}

// TODO: check that this update is necessary, e.g. add some flag to all UPs that should cause an update here
m_pSelectedModel->GetModel()->DoCreateStructure();

UpdateUnitParamTable();
UpdateListValuesTable();

Expand Down
8 changes: 2 additions & 6 deletions GUIDialogs/FlowsheetEditor/FlowsheetEditor.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,18 @@
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonDebug.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonRelease.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt_defaults.props')">
<Import Project="$(QtMsBuild)\qt_defaults.props" />
</ImportGroup>
<PropertyGroup Label="QtSettings" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<QtInstall>msvc2019_64</QtInstall>
<QtModules>widgets</QtModules>
Expand Down Expand Up @@ -102,9 +101,6 @@
<ItemGroup>
<ClInclude Include="GraphvizHandler.h" />
</ItemGroup>
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.props')">
<Import Project="$(QtMsBuild)\qt.props" />
</ImportGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.targets')">
<Import Project="$(QtMsBuild)\qt.targets" />
Expand Down
10 changes: 5 additions & 5 deletions GUIDialogs/GridEditor/DimensionParameters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ EDistrTypes CDimensionParameters::GetDistributionType() const
void CDimensionParameters::SetupComboBoxDistribution() const
{
[[maybe_unused]] CSignalBlocker blocker{ ui.comboDistribution };
const auto types = E2I(std::vector{ DISTR_TYPES });
const auto names = std::vector<QString>{ DISTR_NAMES };
const auto& types = E2I(std::vector<EDistrTypes>{ std::begin(DISTR_TYPES), std::end(DISTR_TYPES) });
std::vector<std::string> names{ std::begin(DISTR_NAMES), std::end(DISTR_NAMES) };;
ui.comboDistribution->addItem("", DISTR_UNDEFINED);
for (size_t i = 0; i < names.size(); ++i)
{
ui.comboDistribution->addItem(names[i], types[i]);
ui.comboDistribution->addItem(QString::fromStdString(names[i]), types[i]);
// disable compounds
if (types[i] == DISTR_COMPOUNDS)
{
Expand All @@ -54,7 +54,7 @@ void CDimensionParameters::SetupComboBoxDistribution() const
}
}
// always show all entries
ui.comboDistribution->setMaxVisibleItems(DISTRIBUTIONS_NUMBER + 1);
ui.comboDistribution->setMaxVisibleItems(std::size(DISTR_TYPES) + 1);
}

void CDimensionParameters::SetupComboBoxEntry() const
Expand Down Expand Up @@ -398,7 +398,7 @@ bool CDimensionParameters::IsValid() const
if (m_grid->DimensionType() == DISTR_UNDEFINED)
return SetMessageAndReturn(StrConst::GE_ErrorUndefined);
const auto iName = GetDistributionTypeIndex(static_cast<EDistrTypes>(ui.comboDistribution->currentData().toUInt()));
const auto distrName = iName != -1 ? std::vector<std::string>(DISTR_NAMES)[iName] : "";
const auto distrName = iName != -1 ? DISTR_NAMES[iName] : "";
if (m_grid->GridType() == EGridEntry::GRID_NUMERIC)
{
const auto& grid = dynamic_cast<CGridDimensionNumeric*>(m_grid.get())->Grid();
Expand Down
2 changes: 1 addition & 1 deletion GUIDialogs/GridEditor/GridEditor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ void CGridEditor::RemDistributionClicked()
if (row <= 0 || row >= ui.listDims->count()) return;
const auto* widget = dynamic_cast<CDimensionParameters*>(ui.listDims->itemWidget(ui.listDims->currentItem()));
const int iName = GetDistributionTypeIndex(widget->GetDistributionType());
const auto name = iName != -1 ? std::vector<QString>(DISTR_NAMES)[iName] : "";
const auto name = iName != -1 ? DISTR_NAMES[iName] : "";
const auto reply = QMessageBox::question(this, "Confirm removal", tr("Remove distribution '%1'?").arg(name), QMessageBox::Yes | QMessageBox::No);
if (reply != QMessageBox::Yes) return;
delete ui.listDims->takeItem(row);
Expand Down
8 changes: 2 additions & 6 deletions GUIDialogs/GridEditor/GridEditor.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,18 @@
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonDebug.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonRelease.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt_defaults.props')">
<Import Project="$(QtMsBuild)\qt_defaults.props" />
</ImportGroup>
<PropertyGroup Label="QtSettings" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<QtInstall>msvc2019_64</QtInstall>
<QtModules>widgets</QtModules>
Expand All @@ -90,9 +89,6 @@
<PropertyGroup>
<_ProjectFileVersion>10.0.40219.1</_ProjectFileVersion>
</PropertyGroup>
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.props')">
<Import Project="$(QtMsBuild)\qt.props" />
</ImportGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.targets')">
<Import Project="$(QtMsBuild)\qt.targets" />
Expand Down
8 changes: 2 additions & 6 deletions GUIDialogs/HoldupsEditor/HoldupsEditor.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,18 @@
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonDebug.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
<Import Project="$(QtMsBuild)\Qt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonQt.props" />
<Import Project="$(SolutionDir)PropertySheets\CommonRelease.props" />
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt_defaults.props')">
<Import Project="$(QtMsBuild)\qt_defaults.props" />
</ImportGroup>
<PropertyGroup Label="QtSettings" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<QtInstall>msvc2019_64</QtInstall>
<QtModules>widgets</QtModules>
Expand All @@ -75,9 +74,6 @@
<PropertyGroup>
<_ProjectFileVersion>10.0.40219.1</_ProjectFileVersion>
</PropertyGroup>
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.props')">
<Import Project="$(QtMsBuild)\qt.props" />
</ImportGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Condition="Exists('$(QtMsBuild)\qt.targets')">
<Import Project="$(QtMsBuild)\qt.targets" />
Expand Down
Loading
Loading