Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-7942] Catch exception during undo operation. #15812

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

reddyashish
Copy link
Contributor

Purpose

https://jira.autodesk.com/browse/DYN-7942

The PopActionGroupFromUndoStack() throws an invalid operation exception when the undo stack is empty. We are not catching it and returning the value directly in PopFromUndoGroup(). So added the try catch for that.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

[DYN-7942] Catch exception during undo operation.

Reviewers

@zeusongit @QilongTang

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7942

Copy link

github-actions bot commented Feb 6, 2025

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

}
catch (InvalidOperationException ex)
{
Log(ex);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this logging to Dynamo Console?

Copy link
Contributor Author

@reddyashish reddyashish Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the log(exception) is logged as error to the log file.

@QilongTang QilongTang requested a review from zeusongit February 6, 2025 18:04
@zeusongit
Copy link
Contributor

1 test failed, seems related.

@zeusongit zeusongit merged commit 5f77cfc into DynamoDS:master Feb 6, 2025
24 checks passed
@QilongTang QilongTang added this to the 3.5 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants