Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5525: Update Insert Graph Window Title #15788

Merged

Conversation

johnpierson
Copy link
Member

@johnpierson johnpierson commented Jan 28, 2025

Update based on comments here: https://jira.autodesk.com/browse/DYN-5525

This PR originally changed it to "Insert Dynamo Definition" #13705

Purpose

Update insert graph title to "Insert Dynamo Graph..."
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@sm6srw

FYIs

@Amoursol @hwahlstrom @dnenov

Update based on comments here: https://jira.autodesk.com/browse/DYN-5525

This PR originally changed it to "Insert Dynamo Definition"
DynamoDS#13705
@johnpierson johnpierson mentioned this pull request Jan 28, 2025
8 tasks
@github-actions github-actions bot changed the title Update Insert Graph Window Title DYN-5525: Update Insert Graph Window Title Jan 28, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-5525

Copy link
Contributor

@avidit avidit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Bring back search performance improvement (DynamoDS#15789)

* Stabilize tests pt2 (DynamoDS#15779)

* DYN-7268 Improve UX when IDSDK is not installed on system running Dynamo (DynamoDS#15790)

* Improve UI responsiveness when doing node search (DynamoDS#15773)

Co-authored-by: chubakueno <[email protected]>

---------

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: Ashish Aggarwal <[email protected]>
Co-authored-by: chubakueno <[email protected]>
Copy link

github-actions bot commented Feb 4, 2025

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@johnpierson johnpierson requested a review from avidit February 4, 2025 14:36
@johnpierson
Copy link
Member Author

@johnpierson johnpierson merged commit e70ee1c into DynamoDS:master Feb 4, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants