[DYN-7923] CurveMapper node - for testing behavior #15776
Conversation
The node shows in Dynamo with inPorts and outPorts rendered
coordinate system, imput values and resizing works
Comments from catchup implemented
- curve mapper node now shows up in the library - icons working!
…o-matov/Dynamo into DYN-7923-Curve-Mapper-node
…om/ivaylo-matov/Dynamo into DYN-7923-Curve-Mapper-node" This reverts commit 82a7a9c5af25f610a7e335e967d63aeb2cd46bcc, reversing changes made to 2bce244.
need to fix fonts
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7923
| private Point point; | ||
| private bool isEnabled = true; | ||
|
|
||
| public bool IsOrthogonal { get; set; } |
There was a problem hiding this comment.
Missing comments for some public properties.
There was a problem hiding this comment.
I know, I'll go over all and add the comments. Need to register in the API as well. Likely that I will rewrite all in clean branch.
| @@ -45,7 +45,7 @@ | |||
| // to distinguish one build from another. AssemblyFileVersion is specified | |||
| // in AssemblyVersionInfo.cs so that it can be easily incremented by the | |||
| // automated build process. | |||
| [assembly: AssemblyVersion("3.5.0.6885")] | |||
| [assembly: AssemblyVersion("3.5.0.7603")] | |||
There was a problem hiding this comment.
Do not commit this file.
| Background="Transparent" | ||
| WindowStyle="None"> | ||
| <dww:ModelessChildWindow | ||
| x:Class="PythonNodeModelsWpf.ScriptEditorWindow" |
There was a problem hiding this comment.
Why do we have changes to python script editor here? Looks like just alignment and white space changes. Are you using a different VS setting?
| @@ -24,6 +24,8 @@ | |||
| <None Remove="Resources\alert.png" /> | |||
| <None Remove="Resources\convert.png" /> | |||
| <None Remove="Resources\convert_hover.png" /> | |||
| <None Remove="Resources\lock_dafault_16px.png" /> | |||
There was a problem hiding this comment.
Confused as to why these resources are added to this project.
| return (GraphTypes)parameter; | ||
| } | ||
| } | ||
| public class EnumBindingSourceExtension : MarkupExtension |
There was a problem hiding this comment.
Missing comments for public classes
Purpose
Draft PR for @achintyabhat to test behavior.
🚧 Note: This is not intended for merging as the code is still in a rough state. Once the expected behavior is confirmed, I will create a clean branch and move the model and control outside of charts.
@QilongTang, I hope this works for now. If not, let me know, and I can create a new branch right away.
PS: One issue I am aware of and will fix next is that the node executes the default values on the first manual graph run, even when the inPorts are connected.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Draft PR for @achintyabhat to test behavior.
🚧 Note: This is not intended for merging as the code is still in a rough state. Once the expected behavior is confirmed, I will create a clean branch and move the model and control outside of charts.
@QilongTang, I hope this works for now. If not, let me know, and I can create a new branch right away.
PS: One issue I am aware of and will fix next is that the node executes the default values on the first manual graph run, even when the inPorts are connected.
Reviewers
@QilongTang
FYIs
@achintyabhat
@dnenov