DYN-7155: Update libg build that contains fully qualified namespaces for default args #15336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajit-pratap
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7155
sm6srw
reviewed
Jun 20, 2024
| { | ||
| if (namespaces[index] == "ProtoGeometry.dll:Autodesk.DesignScript.Geometry.Panel") | ||
| { | ||
| namespaces[index] = $"ProtoGeometry.dll:{typeof(Autodesk.DesignScript.Geometry.PanelSurface).FullName}"; |
sm6srw
reviewed
Jun 20, 2024
| { | ||
| var namespc = ns.Split(":").LastOrDefault(); | ||
|
|
||
| return namespc != null && namespc.Contains(typeLoadData.Category); |
|
Awesome, thank you for taking additional time to fix for C3D users |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
PanelSurfaceBoundaryConditionnodemodel node appearing even after disabling paneling from under Preferences->ExperimentalTODO:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Geometry nodes now contain fully qualified namespaces for default args to avoid namespace conflicts
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of