Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6603 TSplines Lucene Search #14944

Closed
wants to merge 1 commit into from
Closed

DYN-6603 TSplines Lucene Search #14944

wants to merge 1 commit into from

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Changing weight for TSpline nodes.
Changing the Weight for TSpline nodes at indexing time, so when we are searching terms like "cone", "sphere", "plane" the tsplines nodes will be shown at the top (before the Dynamo out-of-box nodes).

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Changing weight for TSpline nodes.

Reviewers

@QilongTang @reddyashish

FYIs

Changing the Weight for TSpline nodes at indexing time, so when we are searching terms like "cone", "sphere", "plane" the tsplines nodes will be shown at the top (before the Dynamo out-of-box nodes).
@RobertGlobant20
Copy link
Contributor Author

Screenshot showing the behavior before and after my fix.
image

@RobertGlobant20
Copy link
Contributor Author

Screenshot showing the behavior before and after my fix.
image

Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Feb 15, 2024
@QilongTang
Copy link
Contributor

QilongTang commented Feb 15, 2024

hi @RobertGlobant20 The AC of the task is Adjust the weights for the TSplines nodes in the lucene search so that they are shown below the actual geometry nodes. It looks like without any change the search order is correct? Or the before and after state are reversed?

@RobertGlobant20
Copy link
Contributor Author

hi @RobertGlobant20 The AC of the task is Adjust the weights for the TSplines nodes in the lucene search so that they are shown below the actual geometry nodes. It looks like without any change the search order is correct? Or the before and after state are reversed?

@QilongTang yes, you are right (I got confused).
Then nothing needs to be done, probably we will need to assign the Jira task to @avidit for testing to confirm the expected behavior.
I will close this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants