Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-5087] Update package details view to include all info #14851

Merged
merged 38 commits into from
Jan 18, 2024

Conversation

zeusongit
Copy link
Contributor

Purpose

DYN-5087

Add package information to package details view window.
Note: Size is not available from PMClient side, a separate task has been filed to implement that, after that the size column will show values. Until then none will be displayed in that field.

LcFSb4XwxT

In case of no copyright info:

Screenshot 2024-01-16 at 8 00 36 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Add package information to package details view window.

Reviewers

@DynamoDS/dynamo

@zeusongit
Copy link
Contributor Author

zeusongit commented Jan 17, 2024

No idea why the shortcut toolbar change is still showing up, probably something wrong with my git history. :/
Update: Fixed it, now it is just a space addition which is intentional.

Copy link

UI Smoke Tests

Test: failure. 1 passed, 1 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

Copy link

UI Smoke Tests

Test: failure. 1 passed, 1 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Jan 17, 2024
Copy link

UI Smoke Tests

Test: failure. 1 passed, 1 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@zeusongit
Copy link
Contributor Author

@avidit any idea why the smoke tests fail here?

@avidit
Copy link
Contributor

avidit commented Jan 18, 2024

@avidit any idea why the smoke tests fail here?

Looking at the result, the splash screen was not loaded within the wait time (60s)

@zeusongit zeusongit merged commit 58f34e4 into DynamoDS:master Jan 18, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants