Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5656 Preferences Blocking Action Bug #14837

Merged
merged 1 commit into from
Jan 12, 2024
Merged

DYN-5656 Preferences Blocking Action Bug #14837

merged 1 commit into from
Jan 12, 2024

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Fixing bug reported when closing the Preferences panel was still showing the dark background.
If we open the PackageManager from Preferences panel and then back to Preferences panel using the link then after closing preferences the background was still present. So with this fix is removing the background under the described specfic case.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixing bug when closing the Preferences panel was still showing the dark background following a specifc flow.

Reviewers

@QilongTang

FYIs

@avidit

If we open the PackageManager from Preferences panel and then back to Preferences panel using the link then after closing preferences the background was still present.
So with this fix is removing the background under the described specfic case.
@RobertGlobant20
Copy link
Contributor Author

GIF showing the expected behavior under a specfic windows flow.
pKs0AUwJZ8

@QilongTang QilongTang added this to the 3.1 milestone Jan 11, 2024
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang
Copy link
Contributor

@QilongTang QilongTang merged commit d511eaf into DynamoDS:master Jan 12, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants