-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-3] Localize Graphic Scale Unit #14827
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
Somehow self serve did not trigger on this PR, I created job https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/13692/ |
The second run also failed |
Yep, as tibi mentioned in slack, it is because of the polling job failure. |
UI Smoke TestsTest: success. 1 passed, 0 failed. |
Thanks, looks like passing at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/13696/. Please cherry-pick |
Purpose
The settings file save the unit in english, hence the bug when moving to another language. Created a Map from english to localized environment. This should fix all edge cases. The settings file will always save in english language to avoid any breaking changes.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@avidit @QilongTang