DYN-8268: fix noNetworkMode for PM client (#15809)

DynamoDS · Feb 6, 2025 · 41d8912 · 41d8912
1 parent 5f77cfc
commit 41d8912
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/DynamoPackages/PackageManagerClient.cs b/src/DynamoPackages/PackageManagerClient.cs
@@ -57,8 +57,6 @@ internal PackageManagerClient(IGregClient client, IPackageUploadBuilder builder,
             this.uploadBuilder = builder;
             this.client = client;
             this.packageMaintainers = new Dictionary<string, bool>();
-
-            this.LoadCompatibilityMap();  // Load the compatibility map
         }
 
         internal bool Upvote(string packageId)
@@ -370,7 +368,7 @@ internal static Dictionary<string, Dictionary<string, string>> GetCompatibilityM
         /// <summary>
         /// Method to load the map once, making it accessible to all elements
         /// </summary>
-        private void LoadCompatibilityMap()
+        internal void LoadCompatibilityMap()
         {
             if (compatibilityMap == null)  // Load only if not already loaded
             {

diff --git a/src/DynamoPackages/PackageManagerExtension.cs b/src/DynamoPackages/PackageManagerExtension.cs
@@ -161,8 +161,16 @@ public void Startup(StartupParams startupParams)
                 new GregClient(startupParams.AuthProvider, url),
                 uploadBuilder, packageUploadDirectory);
 
-            LoadPackages(startupParams.Preferences, startupParams.PathManager);
             noNetworkMode = startupParams.NoNetworkMode;
+
+            //we don't ask dpm for the compatibility map in offline mode.
+            if (!noNetworkMode)
+            {
+                // Load the compatibility map
+                PackageManagerClient.LoadCompatibilityMap();
+            }
+
+            LoadPackages(startupParams.Preferences, startupParams.PathManager);
         }
 
         /// <summary>