Drivelist tests #962
Merged
Drivelist tests #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the devicelist function returned objects in a different order the existing function could return an incorrect mountpoint path. Fixed this by refactoring the method. Additionally, it looks like this method will loop forever until a valid device and mountpoint is found. Unsure if limiting this to a maximum retry count would break things, so leaving as unlimited retries. Signed-off-by: Lawrence Brooks <[email protected]>
Signed-off-by: Lawrence Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: devicelist.list() could return an incorrect mountpoint path if on the first call the appropriate descriptor was found without any mountpoints and the devicelist.list() function returned values in a different order.
Changes:
whileloop with fail fastcontinuestatementsPossible Issue Uncovered:
I have added logic to support enforcing a maximum number of retries and tests to ensure the max is respected but this PR does not put a maximum retry count on the method.