fix: Add tests for the various parsers and cover edge cases #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sanitize numbers to ensure within [0-255] * Gracefully handle incorrect number of values * Simplify logic * Add tests to cover all edge cases Signed-off-by: Lawrence Brooks <[email protected]>
Signed-off-by: Lawrence Brooks <[email protected]>
Signed-off-by: Lawrence Brooks <[email protected]>
lbrooks
changed the title
Signed-off-by: Lawrence Brooks <[email protected]>
lbrooks
changed the title
* colormap values are [0-palette_length) * palette_length is undefined, just ensure [0 * keymap values are [0-??), just ensure [0 * palette values are [0-255], ensure [0-255] Signed-off-by: Lawrence Brooks <[email protected]>
|
Hey, @lbrooks !! Thanks for your contribution! I have been adding tests to cover better all the possible macro scenarios. With the expanded coverage using a backup as a data source, the tests fail with the refactored function, so, could you check it? |
|
I'm closing this one as it's gone through a number of updates and depends on fixing the Focus.unit.ts file (ignoring the test case due to the change in how SerialPort is imported). I will cherry pick the tests and refactoring in this PR to another PR which doesn't have the additional noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of updates to the method: