Enable slitless spectroscopic features (prism and grism) with Roman optical models#73
Open
arunkannawadi wants to merge 36 commits intomainfrom
Open
Enable slitless spectroscopic features (prism and grism) with Roman optical models#73arunkannawadi wants to merge 36 commits intomainfrom
arunkannawadi wants to merge 36 commits intomainfrom
Conversation
Member
Author
|
I'll format the code shortly, but otherwise the code is ready for review. |
and more filter to filter_ changes.
Attempt 1. Likely buggy. This duplicates the class in https://github.com/Roman-Supernova-PIT/galsim-slitless-spec/blob/main/slitlessspec.py.
He did three things: 1. got the code to work equally well for prism or grism 2. included a new method to compute the dispersion (ie. dlam/dr, where dr is the path along the trace)cleaned up a few things regarding how they do intermediate trsnforms for the wavelength. Long story, but tl;dr is they use dy = polynomial(log10(lambda)) 3. generalized a bit the function log10() so that we can use different transformations.
arunkannawadi
force-pushed
the
slitless
branch
from
4b95763 to
a73b04f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.