Open
Conversation
sidneymau
reviewed
Sep 5, 2025
| obseq_data: | ||
| file_name: /lus/grand/projects/RomanDESC/final_roman_runfiles/was/Roman_WAS_obseq_11_1_23.fits | ||
| visit: 80840 | ||
| file_name: /hpc/group/cosmology/RomanDESC_sims_2024/RomanWAS/Roman_WAS_obseq_11_1_23.fits |
Contributor
There was a problem hiding this comment.
Should be /hpc/group/cosmology/OpenUniverse2024/RomanWAS/Roman_WAS_obseq_11_1_23.fits
sidneymau
reviewed
Sep 5, 2025
|
|
||
| nfiles: 1 | ||
| dir: /lus/grand/projects/RomanDESC/roman_output/RomanWAS/images/truth | ||
| dir: RomanWAS/images/simple_model |
Contributor
There was a problem hiding this comment.
should be RomanWAS/images/truth
Contributor
There was a problem hiding this comment.
Though this seems to break with this bit of code: https://github.com/DukeCosmology/roman_imsim/blob/main/roman_imsim/detector_physics.py#L177-L184
sidneymau
reviewed
Sep 5, 2025
| format: "%s/%i/Roman_WAS_truth_%s_%i_%i.fits.gz" | ||
| items: | ||
| - { type: ObSeqData, field: filter } | ||
| - { type: ObSeqData, field: visit } |
Contributor
There was a problem hiding this comment.
This breaks the assumption in https://github.com/DukeCosmology/roman_imsim/blob/main/roman_imsim/detector_physics.py#L130 that the output file_name has three items
sidneymau
reviewed
Sep 5, 2025
| format: "%s/%i/Roman_WAS_index_%s_%i_%i.txt" | ||
| items: | ||
| - { type: ObSeqData, field: filter } | ||
| - { type: ObSeqData, field: visit } |
Contributor
There was a problem hiding this comment.
Same as comment for lines 138--139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the paths and folder structure to correspond to those on DCC, so that it's runnable out of the box.