Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFi OM update from NetworkStatusResponse #592

Open
wants to merge 2 commits into
base: 3.5-dev
Choose a base branch
from

Conversation

rechrtb
Copy link
Contributor

@rechrtb rechrtb commented Nov 13, 2022

This makes sure that the fields needed for the OM are updated from NetworkStatusResponse.

Related to: Duet3D/WiFiSocketServerRTOS#41.

@rechrtb rechrtb force-pushed the add_wifi_om branch 6 times, most recently from 9aaaa68 to 5af5522 Compare November 14, 2022 11:10
@rechrtb rechrtb changed the title Update wifi interface OM fields WiFi OM improvements Nov 14, 2022
@rechrtb rechrtb changed the title WiFi OM improvements WiFi OM update from NetworkStatusResponse Nov 14, 2022
Copy link
Collaborator

@dc42 dc42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Does the additional status polling affect the file upload speed?

@rechrtb
Copy link
Contributor Author

rechrtb commented Nov 25, 2022

Hi @dc42, there doesn't seem to be an appreciable difference.

@rechrtb rechrtb marked this pull request as ready for review November 25, 2022 06:48
@rechrtb
Copy link
Contributor Author

rechrtb commented Nov 25, 2022

@dc42 What do you think about parsing and storing major and minor version number as done here: 67328fe

Gives me the option of using the padding fields in the struct, and if there is issue there is a visible error message at the start (might even opt to re-disable the module instead of just displaying the error message).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants