Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress M261.1 Modbus comm error when V passed #1035

Open
wants to merge 1 commit into
base: 3.6-dev
Choose a base branch
from

Conversation

benagricola
Copy link

Quick overview on the forum - but in short, it is already possible to check the status of the Modbus request by checking that the value of the variable is not null.

The error message output by M261.1 on Modbus communication failure is unnecessary for reads where the null result ends up in a variable anyway, and just ends up spamming the console when using the command programmatically.

src/Platform/Platform.cpp Outdated Show resolved Hide resolved
@benagricola benagricola force-pushed the 3.6-dev branch 2 times, most recently from 8713a5c to 318db3a Compare August 21, 2024 13:09
@benagricola
Copy link
Author

Whoops, capitalisation error in the previous commit (nullPtr != nullptr 🤦) - fixed now, should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants