Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands for managing boosting roles #19

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

itswilliboy
Copy link

No description provided.

Copy link
Member

@LeoCx1000 LeoCx1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues I noticed...

cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
@crygup
Copy link
Member

crygup commented Oct 16, 2023

BOOSTER_ROLE_ID is only used once in the same file and redundant, use premium_subscriber_role

@LeoCx1000 LeoCx1000 added the enhancement New feature or request label Oct 16, 2023
@itswilliboy itswilliboy marked this pull request as draft October 17, 2023 16:55
@itswilliboy itswilliboy marked this pull request as ready for review October 28, 2023 11:14
Copy link
Member

@LeoCx1000 LeoCx1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mostly good. Some things I have noticed are the following

  • roles are crated at the bottom, and will need to be moved to role 1079187727695740960's position + 1.
  • the current database schema and code doesn't seem to account for when an emoji is a default emoji. Trying to read a default emoji will ValueError.
    Other than that, everything seems fine.

Copy link
Member

@Hadock-is-ok Hadock-is-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't see any more issues other than what leo said.

cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
Copy link
Member

@LeoCx1000 LeoCx1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine but a few things that need changes:

cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Show resolved Hide resolved
cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Show resolved Hide resolved
cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Outdated Show resolved Hide resolved
cogs/hideout/boost_roles.py Show resolved Hide resolved
Copy link
Member

@Hadock-is-ok Hadock-is-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants