fix(auth-eth): retry verifyDeployment for public RPC latency #505
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public RPC endpoints may return stale data right after a transaction is mined, causing getCode() to return '0x' and the deploy script to fail with "Contract deployment failed - no code at address" even though the contract was deployed successfully. Add retry with linear back-off (5 attempts, 2s/4s/6s/8s/10s) to verifyDeployment() so deployments on public RPCs succeed without manual intervention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
verifyDeployment()inkms/auth-eth/lib/deployment-helpers.tsgetCode()to return'0x'and the deploy script to fail with"Contract deployment failed - no code at address"even though the contract was deployed successfullyhttps://sepolia.base.org— the contract was on-chain but the script errored outTest plan
npx hardhat kms:deploy --with-app-impl --network custom, previously failed with the race condition error, now should retry and succeed