Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a universal apk by using bundletool on CI #650

Merged
merged 3 commits into from
Jan 27, 2019
Merged

Generate a universal apk by using bundletool on CI #650

merged 3 commits into from
Jan 27, 2019

Conversation

jmatsu
Copy link
Contributor

@jmatsu jmatsu commented Jan 27, 2019

Issue

Overview (Required)

  • It seems assemble tasks cannot embed Dynamic feature's files.
  • DeployGate doesn't support apks/aab upload currently, so we need to prepare the universal apk somehow. bundletool is the easiest way to do this.

Links

@jmatsu jmatsu added the wip label Jan 27, 2019
@jmatsu-bot
Copy link
Collaborator

Try it via https://deploygate.com/distributions/09f9a63daf52203415533a3e79caf0b5c3501813

@jmatsu-bot
Copy link
Collaborator

Apk comparision results

Property Summary
New File Size 13242987 Bytes. (12.63 MB)
File Size Change -881051 Bytes. (-860.4 KB)
Download Size Change -895847 Bytes. (-874.85 KB)
New Method Reference Count 156917
Method Reference Count Change 0
New Number of dex file(s) 4
Number of dex file(s) Change 0

Generated by 🚫 Danger

@jmatsu jmatsu removed the wip label Jan 27, 2019
@jmatsu-bot
Copy link
Collaborator

Asserted successfully. 💯

Generated by 🚫 Danger

@jmatsu
Copy link
Contributor Author

jmatsu commented Jan 27, 2019

Worked 🎉 Let me merge.

@jmatsu jmatsu merged commit e5e9995 into master Jan 27, 2019
@jmatsu jmatsu deleted the changed_apk_generate branch January 27, 2019 09:25
@jmatsu jmatsu mentioned this pull request Jan 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmatsu @jmatsu-bot