Enable vertical scrolling in waveform view #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent window from shrinking by one pixel when resizing one dimension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables vertical scrolling of the waveform view.
When reducing the window size, it will not attempt to squeeze all waveforms into the window which makes them unreadable.
Instead, when a minimum height is reached, the waveforms maintain their size and a vertical scrollbar can be used to scroll the view.
This makes it easier to hide unneeded signals e.g. when using (especially parallel) decoders.
In addition, an off-by-one error is fixed for window resizing. The last pixel of width and height is inclusive so it needs to be added to the new calculated form dimensions.
Caveat: I only have a DSLogic device; this change is untested for DSCope.