Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only subscribe if actions are available #403

Open
wants to merge 3 commits into
base: v1.x.y
Choose a base branch
from

Conversation

leon1995
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the changelog accordingly.
  • I have added tests to cover my changes.

@leon1995 leon1995 added the v1 Version 1 is affected label Nov 22, 2024
@leon1995 leon1995 self-assigned this Nov 22, 2024
@leon1995 leon1995 linked an issue Nov 22, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.20%. Comparing base (c3e989a) to head (e01d8ca).

Files with missing lines Patch % Lines
src/sdc11073/sdcclient/sdcclientimpl.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v1.x.y     #403      +/-   ##
==========================================
+ Coverage   86.11%   86.20%   +0.08%     
==========================================
  Files          65       65              
  Lines       11986    11987       +1     
==========================================
+ Hits        10322    10333      +11     
+ Misses       1664     1654      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 Version 1 is affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: consumer tries to subscribe even if there are no actions to subscribe to
2 participants