fixed ruff findings

Draegerwerk · Nov 22, 2024 · 85d62d8 · 85d62d8
1 parent 2075091
commit 85d62d8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/sdc11073/mdib/mdibbase.py b/src/sdc11073/mdib/mdibbase.py
@@ -282,9 +282,9 @@ def update(self):
                 orig = states_dict[state.Handle]
                 state.update_from_other_container(orig)
             except KeyError:
-                self.states.pop(state.handle)
+                self.states.pop(state.Handle)
         # add new states
-        for handle in states_dict:
+        for handle, _ in states_dict.items():
             if handle not in self.states:
                 self.states[handle] = states_dict[handle].mk_copy()
 

diff --git a/src/sdc11073/provider/providerimpl.py b/src/sdc11073/provider/providerimpl.py
@@ -22,9 +22,6 @@
 from sdc11073.httpserver.httpserverimpl import HttpServerThreadBase
 from sdc11073.namespaces import WSA_ANONYMOUS
 from sdc11073.pysoap.soapclientpool import SoapClientPool
-
-# import ProductProtocol, WaveformProviderProtocol here for code cov. :(
-from sdc11073.roles.protocols import ProductProtocol, WaveformProviderProtocol  # noqa: TCH001
 from sdc11073.xml_types import mex_types
 from sdc11073.xml_types.addressing_types import EndpointReferenceType
 from sdc11073.xml_types.dpws_types import HostServiceType, ThisDeviceType, ThisModelType
@@ -42,6 +39,7 @@
     from sdc11073.provider.porttypes.localizationservice import LocalizationStorage
     from sdc11073.pysoap.msgfactory import CreatedMessage
     from sdc11073.pysoap.soapenvelope import ReceivedSoapMessage
+    from sdc11073.roles.protocols import ProductProtocol, WaveformProviderProtocol
     from sdc11073.xml_types.msg_types import AbstractSet
     from sdc11073.xml_types.pm_types import InstanceIdentifier
     from sdc11073.xml_types.wsd_types import ScopesType

diff --git a/src/sdc11073/wsdiscovery/wsdimpl.py b/src/sdc11073/wsdiscovery/wsdimpl.py
@@ -347,7 +347,7 @@ def _add_remote_service(self, service: Service):
         already_known_service = self._remote_services.get(service.epr)
         if not already_known_service:
             self._remote_services[service.epr] = service
-            self._logger.info('new remote %r', service)
+            self._logger.info('new remote epr="%s" x_addrs=%r', service.epr, service.x_addrs)
             return
 
         if service.metadata_version == already_known_service.metadata_version: