Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: table add shouldCellUpdate API #2584

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

shijiatongxue
Copy link
Collaborator

@shijiatongxue shijiatongxue commented Nov 21, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Feature

PR description

新增 shouldCellUpdate API,用于自定义单元格的渲染。Table cell 默认使用 isEqaul 深对比 props 是否变化,如用户的 props.record 数据量较大,可能会比较耗时,此时用户可使用 shouldCellUpdate API 自定义渲染。

ps:@douyinfe/[email protected] 添加了此 commit,meego 用。

Changelog

🇨🇳 Chinese

  • Feat: 新增 shouldCellUpdate API,用于自定义单元格的渲染。

🇺🇸 English

  • Feat: table add shouldCellUpdate API

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Nov 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9e2e35:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Nov 21, 2024

semi-design    Run #2959

Run Properties:  status check failed Failed #2959  •  git commit 9e6cb6ac0e ℹ️: Merge a9e2e357c519ecb749a4800b59dd768878bd8bae into a218ee1f8a6ad1ea6a1a6700edf6...
Project semi-design
Branch Review feat/table-cell-shouldUpdate
Run status status check failed Failed #2959
Run duration 07m 57s
Commit git commit 9e6cb6ac0e ℹ️: Merge a9e2e357c519ecb749a4800b59dd768878bd8bae into a218ee1f8a6ad1ea6a1a6700edf6...
Committer Shi Jia
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 276
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

@pointhalo pointhalo merged commit 2cec6ef into release Nov 28, 2024
4 of 6 checks passed
@pointhalo pointhalo deleted the feat/table-cell-shouldUpdate branch November 28, 2024 11:55
Copy link

cypress bot commented Nov 28, 2024

semi-design    Run #2964

Run Properties:  status check passed Passed #2964  •  git commit 2cec6ef7fb: feat: table add shouldCellUpdate API (#2584)
Project semi-design
Branch Review release
Run status status check passed Passed #2964
Run duration 08m 16s
Commit git commit 2cec6ef7fb: feat: table add shouldCellUpdate API (#2584)
Committer Shi Jia
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 277
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants