Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: semi-icons-lab add new icons #2583

Open
wants to merge 3 commits into
base: release
Choose a base branch
from
Open

feat: semi-icons-lab add new icons #2583

wants to merge 3 commits into from

Conversation

pointhalo
Copy link
Collaborator

@pointhalo pointhalo commented Nov 20, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

  • 修改 svgo 配置
    image
    然后重新构建,可见体积减少。视觉效果无明显影响。

  • lerna run build:icon --scope @douyinfe/semi-icons

  • lerna run build:js --scope @douyinfe/semi-icons
    image

  • 新增彩色图标

Changelog

🇨🇳 Chinese

  • Style: @douyinfe/semi-icons-lab 增加新图标: IconChart、IconChat、IconCodeHighlight、IconLottie、IconMarkdown、IconPincode、IconVersionOne、IconWebComponents
  • Chore:修改 @douyinfe/semi-icons 中 svg path 数字精度,保留两位小数,全量图标 min 包体积 450 kb -> 278kb

🇺🇸 English

  • Style: Add new icons to @douyinfe/semi-icons-lab: IconChart, IconChat, IconCodeHighlight, IconLottie, IconMarkdown, IconPincode, IconVersionOne, IconWebComponents.
  • Chore: Modify the numerical precision of svg path in @douyinfe/semi-icons, keep two decimal places. The min package volume of all icons changes from 450 kb to 278 kb.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f90b4a3:

Sandbox Source
pr-story Configuration

@pointhalo pointhalo changed the base branch from main to release November 20, 2024 11:40
Copy link

cypress bot commented Nov 20, 2024

semi-design    Run #2944

Run Properties:  status check passed Passed #2944  •  git commit a2a00ef71b ℹ️: Merge f90b4a34af5d695443ab4d53f79d8a3739f4c401 into 12a3d0cddd5dbb96b2d9e347ad20...
Project semi-design
Branch Review feat-iconsLab
Run status status check passed Passed #2944
Run duration 07m 45s
Commit git commit a2a00ef71b ℹ️: Merge f90b4a34af5d695443ab4d53f79d8a3739f4c401 into 12a3d0cddd5dbb96b2d9e347ad20...
Committer pointhalo
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 276
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant