Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed the unexpected placement area display when dragging elemen… #2580

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: Fixed the unexpected placement area display when dragging elemen… #2580

merged 1 commit into from
Nov 22, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Nov 19, 2024 •
edited
Loading

…ts inside the chat component

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2579
修复后
拖动 Chat 组件内部图片，不会出现意外的放置区域 UI
image

Changelog

🇨🇳 Chinese

🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3eddef4:

Sandbox Source
pr-story Configuration

@cypress Cypress
Copy link

cypress bot commented Nov 19, 2024

semi-design    Run #2941

Run Properties:  status check passed Passed #2941  •  git commit cc22e3ee1e ℹ️: Merge 3eddef4d639f66e98fd6a930efae9ad635c8163e into ea57b6c529460277f4a2f539ad79...
Project semi-design
Branch Review fix/chat-drag
Run status status check passed Passed #2941
Run duration 07m 48s
Commit git commit cc22e3ee1e ℹ️: Merge 3eddef4d639f66e98fd6a930efae9ad635c8163e into ea57b6c529460277f4a2f539ad79...
Committer YyumeiZhang
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 276
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pointhalo pointhalo merged commit ab9cbd8 into main Nov 22, 2024
10 checks passed
@pointhalo pointhalo deleted the fix/chat-drag branch November 22, 2024 04:07
@cypress Cypress
Copy link

cypress bot commented Nov 22, 2024 •
edited
Loading

semi-design    Run #2948

Run Properties:  status check passed Passed #2948  •  git commit ab9cbd84da: fix: Fixed the unexpected placement area display when dragging elements inside t...
Project semi-design
Branch Review main
Run status status check passed Passed #2948
Run duration 07m 52s
Commit git commit ab9cbd84da: fix: Fixed the unexpected placement area display when dragging elements inside t...
Committer YyumeiZhang
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 276
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pointhalo pointhalo Awaiting requested review from pointhalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 拖动 Chat 组件内部的图片时候，意外出现 dropArea
2 participants
@YyumeiZhang @pointhalo