Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: For Tree/TreeSelect with showLine set to true, when the top no… #2571

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Nov 14, 2024

…de is a leaf node, there should be no line in front of the top node

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #
关联问题 #1801

对于 showLine 为 true 的 Tree/TreeSelect,当顶层节点为叶子节点时,顶层节点前不应该有线条

修改前

image

修改后

image

其他

增加 storybook 用例,检测顶层节点为叶子节点的UI表现

Changelog

🇨🇳 Chinese

  • Style: 对于 showLine 为 true 的 Tree/TreeSelect,当顶层节点为叶子节点时,顶层节点前不应该有线条

🇺🇸 English

  • Style: For Tree/TreeSelect with showLine set to true, when the top node is a leaf node, there should be no line in front of the top node.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

…de is a leaf node, there should be no line in front of the top node
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4a72e15:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Nov 14, 2024

semi-design    Run #2919

Run Properties:  status check passed Passed #2919  •  git commit c0297f2a21 ℹ️: Merge 4a72e15a150cffa13ee52b3fb8aa56aac5f5a614 into 55c43bb89487cc2971f4d9774435...
Project semi-design
Branch Review fix/tree-showline-onelevel
Run status status check passed Passed #2919
Run duration 07m 43s
Commit git commit c0297f2a21 ℹ️: Merge 4a72e15a150cffa13ee52b3fb8aa56aac5f5a614 into 55c43bb89487cc2971f4d9774435...
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 275
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@DaiQiangReal DaiQiangReal merged commit 90615f0 into main Nov 22, 2024
9 checks passed
@DaiQiangReal DaiQiangReal deleted the fix/tree-showline-onelevel branch November 22, 2024 03:50
Copy link

cypress bot commented Nov 22, 2024

semi-design    Run #2946

Run Properties:  status check failed Failed #2946  •  git commit 90615f0797: Merge pull request #2571 from DouyinFE/fix/tree-showline-onelevel
Project semi-design
Branch Review main
Run status status check failed Failed #2946
Run duration 07m 50s
Commit git commit 90615f0797: Merge pull request #2571 from DouyinFE/fix/tree-showline-onelevel
Committer 代强
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 275
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants