chore: add prettier script #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenshuai2144
commented
Oct 26, 2021
•
chenshuai2144
commented
- 所有的文件都应该保持一个代码风格
- pr 需要 ci
|
之前加了 yarn.lock 在.gitignore. 需要同步删下 |
chenzn1
reviewed
Nov 17, 2021
| @@ -0,0 +1,37 @@ | |||
| name: lint CI | |||
|
|
|||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
push 也需要的，不然合并到matser的时候master就不会检查了。
There was a problem hiding this comment.
那可以限定一下分支，只在 main test release 这些重要的分支触发。
There was a problem hiding this comment.
没必要的，github 非常 rich，牺牲一点时间保证代码的正确性是非常合算的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.