Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added string and interpolated string literal analyzer to inspect sql … #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/TSqlAnalyzer/TSqlAnalyzer/TSqlAnalyzer.Test/UnitTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,14 @@ private void AnalyzerTest()
VerifyCSharpDiagnostic(test);
}

[TestMethod]
public void Test_NonSqlString_WithSqlPaser()
{
var result = SqlParser.Parse("select a value from Hello Test");

Assert.IsTrue(result.Count == 0, "Non Sql should not parse and returns no errors.");
}

protected override DiagnosticAnalyzer GetCSharpDiagnosticAnalyzer()
{
return new TSqlAnalyzer();
Expand Down
22 changes: 20 additions & 2 deletions src/TSqlAnalyzer/TSqlAnalyzer/TSqlAnalyzer/DiagnosticAnalyzer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,30 @@ public class TSqlAnalyzer : DiagnosticAnalyzer
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get { return ImmutableArray.Create(Rule); } }

public override void Initialize(AnalysisContext context)
{
// TODO: Consider registering other actions that act on syntax instead of or in addition to symbols
{
// TODO: Consider registering other actions that act on syntax instead of or in addition to symbols
context.RegisterSyntaxNodeAction(AnalyzeStringLiteralForSql, SyntaxKind.LocalDeclarationStatement);
context.RegisterSyntaxNodeAction(AnalyzeConstructorNode, SyntaxKind.ObjectCreationExpression);
context.RegisterSyntaxNodeAction(AnalyzeAssignmentNode, SyntaxKind.SimpleAssignmentExpression);
}

private static void AnalyzeStringLiteralForSql(SyntaxNodeAnalysisContext context)
{
var localDeclarationExpression = context.Node as LocalDeclarationStatementSyntax;

var innerObjectInitializers = localDeclarationExpression.DescendantNodes().ToList();

var stringText = innerObjectInitializers.OfType<LiteralExpressionSyntax>().FirstOrDefault(x => x.IsKind(SyntaxKind.StringLiteralExpression) || x.IsKind(SyntaxKind.InterpolatedStringExpression));

if (stringText != null)
{
if (!SqlParser.Parse(stringText.ToFullString()).Any())
return;
}

ExpressionSyntax expressionSyntax = stringText;
RunDiagnostic(context, expressionSyntax);
}
private static void AnalyzeAssignmentNode(SyntaxNodeAnalysisContext context)
{
var assignmentExpression = (AssignmentExpressionSyntax)context.Node;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@ internal class ExpressionDiagnostic
internal static DiagnosticDescriptor RuleParam = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true);

internal static void Run(SyntaxNodeAnalysisContext context, ExpressionSyntax token)
{
string id = token.ToFullString();
{
if (token == null)
return;

string id = token.ToFullString();
if (string.IsNullOrWhiteSpace(id))
return;

Expand Down