Merge pull request #2874 from sharwell/fix-global-namespace

Fix SA1135 getting reported for top-level namespaces
DotNetAnalyzers · Feb 6, 2019 · cef4b3a · cef4b3a
2 parents b40215f + feddb3e
commit cef4b3a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1135UnitTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1135UnitTests.cs
@@ -307,5 +307,17 @@ namespace Test
 
             await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
         }
+
+        [Fact]
+        public async Task TestFullyQualifiedTopLevelNamespaceAsync()
+        {
+            var testCode = @"
+namespace MyNamespace {
+  using System;
+}
+";
+
+            await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
     }
 }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Helpers/SymbolNameHelpers.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Helpers/SymbolNameHelpers.cs
@@ -85,10 +85,14 @@ private static void AppendQualifiedSymbolName(StringBuilder builder, ISymbol sym
                 break;
 
             default:
-                builder
-                    .Append(symbol.ContainingNamespace.ToDisplayString())
-                    .Append(".")
-                    .Append(symbol.Name);
+                if (!symbol.ContainingNamespace.IsGlobalNamespace)
+                {
+                    builder
+                        .Append(symbol.ContainingNamespace.ToDisplayString())
+                        .Append(".");
+                }
+
+                builder.Append(symbol.Name);
                 break;
             }
         }