Merge pull request #22 from tristal/issue/21

Allowing UseAsyncSuffixAnalyzer to ignore property getter and setters
DotNetAnalyzers · May 6, 2015 · 844ec04 · 844ec04
2 parents 79ddddc + db8f860
commit 844ec04
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/AsyncUsageAnalyzers/AsyncUsageAnalyzers.Test/Naming/UseAsyncSuffixUnitTests.cs b/AsyncUsageAnalyzers/AsyncUsageAnalyzers.Test/Naming/UseAsyncSuffixUnitTests.cs
@@ -143,6 +143,19 @@ class ClassName
             await VerifyCSharpFixAsync(testCode, fixedCode, cancellationToken: CancellationToken.None).ConfigureAwait(false);
         }
 
+        [Fact]
+        public async Task TestPropertyGetterAndSetterTaskAsync()
+        {
+            string testCode = @"
+using System.Threading.Tasks;
+class ClassName
+{
+    public Task<string> TaskString { get; set; }
+}
+";
+            await VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
         protected override DiagnosticAnalyzer GetCSharpDiagnosticAnalyzer()
         {
             return new UseAsyncSuffixAnalyzer();

diff --git a/AsyncUsageAnalyzers/AsyncUsageAnalyzers/Naming/UseAsyncSuffixAnalyzer.cs b/AsyncUsageAnalyzers/AsyncUsageAnalyzers/Naming/UseAsyncSuffixAnalyzer.cs
@@ -58,6 +58,9 @@ private void HandleMethodDeclaration(SymbolAnalysisContext context)
             if (!string.Equals(typeof(Task).Namespace, symbol.ReturnType?.ContainingNamespace?.ToString(), StringComparison.Ordinal))
                 return;
 
+            if (symbol.MethodKind == MethodKind.PropertyGet || symbol.MethodKind == MethodKind.PropertySet)
+                return;
+
             context.ReportDiagnostic(Diagnostic.Create(Descriptor, symbol.Locations[0], symbol.Name));
         }
     }