Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Reference New Operator #5

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Reference New Operator #5

merged 1 commit into from
Jun 14, 2021

Conversation

nmanoogian
Copy link
Member

No description provided.

Copy link

@rgmvisser rgmvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it a little bit bigger and more prominent? :)

@nmanoogian nmanoogian force-pushed the nic/reference-new-operator branch from f570213 to 15577c4 Compare June 14, 2021 15:00
@nmanoogian
Copy link
Member Author

Can we make it a little bit bigger and more prominent? :)

How's that? The only way to really make it bigger is by putting it into a header, which always felt a little hacky to me. I'm not opposed though.

@rgmvisser
Copy link

Can we make it a little bit bigger and more prominent? :)

How's that? The only way to really make it bigger is by putting it into a header, which always felt a little hacky to me. I'm not opposed though.

Yeah probably an H1 or H2, maybe in combination of something like this? https://stackoverflow.com/questions/58737436/how-to-create-a-good-looking-notification-or-warning-box-in-github-flavoured-mar

@nmanoogian nmanoogian force-pushed the nic/reference-new-operator branch from 15577c4 to 3638bee Compare June 14, 2021 16:27
@nmanoogian
Copy link
Member Author

I like the table trick! Let me know what you think about that.

@rgmvisser
Copy link

Looks good, I would place it above the header though with some whitespace under it, otherwise it is easy to glance over

@nmanoogian nmanoogian force-pushed the nic/reference-new-operator branch from 3638bee to 419f474 Compare June 14, 2021 17:06
@nmanoogian nmanoogian requested a review from rgmvisser June 14, 2021 17:07
@nmanoogian nmanoogian merged commit 5d2d008 into main Jun 14, 2021
@nmanoogian nmanoogian deleted the nic/reference-new-operator branch June 14, 2021 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants