Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Use tini to ensure container exits on SIGTERM #3

Merged
merged 2 commits into from
May 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ spec:
containers:
- name: doppler-secrets
image: alpine
command: ['/bin/sh', '-c', 'printenv && sleep 3600'] # Test by printing env var names
command: ['/bin/sh', '-c', 'apk add --no-cache tini > /dev/null 2>&1 && printenv | grep -v KUBERNETES_ && tini -s tail -f /dev/null'] # Test by printing env var names
envFrom: # Only envFrom is currently supported for auto-reloads
- secretRef:
name: app-secret # Should match DopplerSecret.spec.secretName
Expand Down
2 changes: 1 addition & 1 deletion doppler-crd-controller.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ rules:
verbs: ['get', 'create', 'update', 'delete']
- apiGroups: ['apps']
resources: ['deployments']
verbs: ['patch']
verbs: ['list', 'patch']
- apiGroups: ['']
resources: ['namespaces']
verbs: ['get', 'watch', 'list']
Expand Down
2 changes: 1 addition & 1 deletion example/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
containers:
- name: doppler-secrets
image: alpine
command: ['/bin/sh', '-c', 'printenv && sleep 3600'] # Test by printing env var names
command: ['/bin/sh', '-c', 'apk add --no-cache tini > /dev/null 2>&1 && printenv | grep -v KUBERNETES_ && tini -s tail -f /dev/null'] # Test by printing env var names
imagePullPolicy: Always
envFrom:
- secretRef:
Expand Down