Added captions to quote, did some refactoring.#4
Added captions to quote, did some refactoring.#4Fibii wants to merge 1 commit intoDoppeey:masterfrom Fibii:master
Conversation
RicardoMonteiroSimoes
left a comment
RicardoMonteiroSimoes
left a comment
There was a problem hiding this comment.
I'd suggest trying to fix that nested try/catch. Maybe even try to get rid of all try catch.
Also, no idea why the hell github want's me to review this. Well, here I am ~F4nt0M
| + "\nQuoted by " + commandEvent.getMember().getAsMention() + " with the caption:\n" + caption); | ||
| } | ||
|
|
||
| try { |
There was a problem hiding this comment.
nested try/catch? I'd suggest you use the isEmpty() functionality to check if it has anything.
There was a problem hiding this comment.
if there's no image, x.getAttachments().get(0) will throw an exception, i tried to fix it before pushing but i couldn't because i'm not familiar with JDA.
There was a problem hiding this comment.
I'll have to check it out at home. I think I fixed it in #5 using if(!yadda.yadda().isEmpty()){ and then using get get(0) command. I did not remove the try catch tho - that is merely due to the fact that I left it in in case I missed something.
2 participants
added captions, removed the ability to quote quotes or meaningless messages (like those messages with no characters at all)