Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch to a different completed tasks endpoint #200

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scottlovegrove
Copy link
Contributor

@scottlovegrove scottlovegrove commented Dec 3, 2024

Overview

The endpoint we were using for completed tasks is being deprecated and we need to move to a new one.

Initially this would have been to move to archive/items, but this is to be renamed shortly to tasks/archived. I've gone with the latter here, even though it's not live, so this PR can't be merged until this one on the backend has been.

I've also increased the limit to 200, as per the docs of the endpoint to be used to decrease the number of times we may have to call it.

Reference

PR to deprecate the existing endpoint: https://github.com/Doist/Todoist/pull/19393
PR to rename endpoint: https://github.com/Doist/Todoist/pull/19394

Test Plan

  • Run the extension
  • Export a project known to have completed tasks
    • The completed tasks show in the exported google sheet.

@scottlovegrove scottlovegrove self-assigned this Dec 3, 2024
@scottlovegrove scottlovegrove force-pushed the scottl/completed-tasks-api-change branch from ae98783 to 9edf899 Compare December 3, 2024 09:43
@scottlovegrove scottlovegrove force-pushed the scottl/completed-tasks-api-change branch from 9edf899 to 8ea8203 Compare December 3, 2024 10:24
@scottlovegrove
Copy link
Contributor Author

The order in which PRs should be merged are as follows:

  1. PR to rename endpoint (ref)
  2. This PR (once the PR from 1 is deployed)
  3. PR to deprecate old endpoint (ref)

@nats12 I've tagged you in this as the frontend's API update person. If you need assistance to test the PR when (1) has been merged, please speak to Pawel or Francesca, but it should be easy enough to get going.

@PotHix for visibility.

Copy link

@nats12 nats12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@PotHix
Copy link
Member

PotHix commented Dec 3, 2024

  1. PR to deprecate old endpoint (ref)

3 can be merged in any order. The deprecation of the endpoint will only affect new minor versions, and the actual deprecation of v9 will happen ~Q2 2025.

@nats12 I will ping you as soon as the changes are in place. @scottlovegrove will be OOO for holidays soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants