Apply unused return value checker #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ointSetUnion`, and add `@IgnorableReturnValue` annotations.
There was a problem hiding this comment.
Pull request overview
Enables stricter Kotlin compiler return-value checking and updates affected APIs/tests accordingly, including a small refactor in DisjointSetUnion for path compression.
Changes:
- Enable
allWarningsAsErrorsand-Xreturn-value-checker=fullin Gradle Kotlin compiler options. - Refactor
DisjointSetUnion.find()path compression into a dedicatedcompress()helper and annotateunion()as ignorable. - Annotate
MutableMap.decrement()as ignorable and adjust DSU tests to avoid ignoring return values.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/test/kotlin/kodvent/datastructures/DisjointSetUnionTest.kt | Updates a test to accommodate the return-value checker. |
| src/main/kotlin/kodvent/datastructures/DisjointSetUnion.kt | Refactors path compression and marks union() return value as ignorable. |
| src/main/kotlin/kodvent/collections/MapExtensions.kt | Marks decrement() return value as ignorable. |
| build.gradle.kts | Enables stricter compiler settings (warnings-as-errors + return-value checker). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
…lify traversal loops
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable stricter compiler checks, move path compression logic in
DisjointSetUnion, and add@IgnorableReturnValueannotations.