Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use_interval #33

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Conversation

marc2332
Copy link
Collaborator

No description provided.

@marc2332 marc2332 added the enhancement New feature or request label Apr 11, 2024
@marc2332 marc2332 requested a review from DogeDark April 18, 2024 19:35
@marc2332 marc2332 marked this pull request as ready for review April 18, 2024 19:35
Copy link
Member

@DogeDark DogeDark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should follow what I did for use_window_size and have something like utils/timing/mod.rs (utils/timing.rs for now?) Basically categorizing the utilities into related modules. Additionally have a dedicated feature instead of utils. What do you think?

Other than that, it looks good.

@marc2332
Copy link
Collaborator Author

I think we should follow what I did for use_window_size and have something like utils/timing/mod.rs (utils/timing.rs for now?) Basically categorizing the utilities into related modules. Additionally have a dedicated feature instead of utils. What do you think?

Other than that, it looks good.

Yep 💯 Will update this PR asap.

@marc2332 marc2332 requested a review from DogeDark April 21, 2024 13:25
@DogeDark DogeDark merged commit f214e4d into DioxusLabs:master Apr 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants